Skip to content

End epochs for continuous PGF distributions #4408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

End epochs for continuous PGF distributions #4408

wants to merge 1 commit into from

Conversation

@brentstone
Copy link
Collaborator

@brentstone brentstone commented Feb 22, 2025 •
edited
Loading

Describe your changes

Closes #4104. Affects Ledger test vectors and input data format for the init-proposal tx.

Todo:

  • validation
    • client, wasm, maybe VP?

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@brentstone brentstone added the breaking:SDK SDK breaking change label Feb 22, 2025
@codecov
Copy link

codecov bot commented Feb 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.96296% with 70 lines in your changes missing coverage. Please review.

Project coverage is 74.51%. Comparing base (7ca07c9) to head (8177ad2).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
crates/governance/src/pgf/inflation.rs 31.25% 33 Missing ⚠️
crates/governance/src/finalize_block.rs 16.66% 20 Missing ⚠️
crates/governance/src/storage/proposal.rs 73.80% 11 Missing ⚠️
crates/sdk/src/signing.rs 94.11% 4 Missing ⚠️
crates/sdk/src/rpc.rs 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4408      +/-   ##
==========================================
- Coverage   74.53%   74.51%   -0.03%     
==========================================
  Files         339      339              
  Lines      110504   110592      +88     
==========================================
+ Hits        82368    82407      +39     
- Misses      28136    28185      +49

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone force-pushed the brent/cpgf-end-epochs branch from 639dc1d to 8177ad2 Compare February 27, 2025 03:49
@github-actions github-actions bot added the backport-libs-0.251 Backport libraries to 0.251 maintenance branch label Feb 27, 2025
@brentstone brentstone force-pushed the brent/cpgf-end-epochs branch from 171ee31 to b2b8ca2 Compare March 2, 2025 10:03
@brentstone brentstone added the enhancement New feature or request label Mar 2, 2025
@tzemanovic tzemanovic removed the backport-libs-0.251 Backport libraries to 0.251 maintenance branch label Mar 27, 2025
@brentstone brentstone added the breaking: tx Transaction format breaking change label Jun 16, 2025
@tzemanovic tzemanovic force-pushed the brent/cpgf-end-epochs branch from 488f1b2 to 4223b7f Compare October 17, 2025 14:24
@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2025

🧪 CI Insights

Here's what we observed from your CI run for 4223b7f.

❌ Job Failures

Pipeline Job Health on main Retries 🔍 CI Insights 📄 Logs
Lint 🧹 Build 🛠️ Test 🚦 test-unit Healthy 0 View View

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tzemanovic tzemanovic

@brentstone brentstone

Labels

breaking:SDK SDK breaking change breaking: tx Transaction format breaking change enhancement New feature or request governance ledger

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

continuous PGF proposals should have beginning and end epoch options

3 participants

@brentstone @tzemanovic